Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdef: CarbonixCommon: add cx_vtol_info.lua #209

Conversation

robertlong13
Copy link
Collaborator

Alerts the pilots to QAssist, and sends VTOL status and time-in-vtol to the GCS.

SW-337

@robertlong13
Copy link
Collaborator Author

robertlong13 commented Sep 25, 2024

@aidancarbonix tagging you as reviewer so you can test this in SITL, but do please also look through the lua (edit: I think you already did actually)

@aidancarbonix
Copy link

Noting here that at the moment I don't really like the behaviour that it disappears from the HUD while the assist is still ongoing. We are testing to try and get it to stay more consistently.

If possible, I would also remove the "Alt assist: X" alert which is redundant.

@loki077
Copy link
Contributor

loki077 commented Oct 1, 2024

Will merge the code in Cx_built_in_test and raise a PR after which will close this PR.

@aidancarbonix
Copy link

Please tag me in the new PR @loki077 so we can check that the functionality is good :)

@LachlanConn
Copy link
Contributor

Just a couple of requests for this feature is that with the QASSIST message, could we try to ensure that this only occurs in FW when required so for instance we would not see it on the ground, disarmed in FW modes and also not on intentional transitions and reverse transitions. Only for dropping below QAssist speed during normal flight.

@Pradeep-Carbonix Pradeep-Carbonix merged commit 860099b into CxPilot-7 Nov 1, 2024
36 checks passed
@Pradeep-Carbonix Pradeep-Carbonix deleted the feature/SW-337-alert-to-pilots-when-qassist-is-activated branch November 1, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants